Re: [RFC PATCH v3 00/15] Modernize the build system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 25, 2024 at 05:36:00PM +0100, Ramsay Jones wrote:
> 
> 
> On 25/10/2024 06:20, Patrick Steinhardt wrote:
> > On Thu, Oct 24, 2024 at 06:34:24PM +0100, Ramsay Jones wrote:
> >> On 24/10/2024 08:19, Patrick Steinhardt wrote:
> >> Having a quick squint at the failure, it '# failed 1 among 397 test(s)'
> >> which was 'not ok 391 - correct handling of backslashes', which is the
> >> only test marked with a '!CYGWIN' prerequisite! ;) So it seems that I
> >> am doing something wrong, which results in the prerequisite not being
> >> set.
> > 
> > The CYGWIN prerequisite is set depending on whether or not `uname -s`
> > contains "*CYGWIN*". Does your system maybe pick up the wrong uname(1)
> > binary somehow?
> 
> 
> Yep, I suspected that I knew what the problem was, I just had not looked
> to see if my hunch was correct yet! :) And indeed:
> 
>   $ pwd
>   /home/ramsay/git
>   $ ls -l uname*
>   -rw-r--r-- 1 ramsay None  11K Jun 28  2019 uname.c
>   -rwxr-xr-x 1 ramsay None 167K Jun 28  2019 uname.exe*
>   $ ./uname -s
>   Windows
>   $ ./uname -a
>   Windows satellite 10.0 19045() AMD-64 Windows 10 Home
>   $ uname -a
>   CYGWIN_NT-10.0-19045 satellite 3.5.4-1.x86_64 2024-08-25 16:52 UTC x86_64 Cygwin
>   $
> 
> As you can see, many many moons ago (28 Jun 2019 was just the last time
> it was updated/built - I suspect it was first written in 2006), I had
> written my own version of uname. If memory serves, it was actually for
> the 'msys' version, not cygwin! ;)
> 
> Anyway, when the test executes my PATH starts:
> 
>     /home/ramsay/git/build/bin-wrappers:/home/ramsay/git:/usr/bin ...
> 
> It is not immediately obvious why '/home/ramsay/git' is in there, but
> if I move my uname out of the way:
> 
>   $ mv uname* ../src
>   $ ls -l uname*
>   ls: cannot access 'uname*': No such file or directory
>   $ 

Interesting. I guess that `find_program()` finds some of the required
binaries in the Git directory itself, which sounds wrong to me. I'll
have a look at this.

Patrick




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux