"Kristoffer Haugsbakk" <kristofferhaugsbakk@xxxxxxxxxxxx> writes:
> Hi
>
> This looks correct according to CodingGuidelines, part “For shell
> scripts”.
>
> • Whitespace and redirect operator
> • Case arms indentation
> • Tabs for indentation. It might look like some of the lines in the
> preimage (term?) use two nesting levels set to four columns, but that
> is because the first line is indented by four spaces and the next line
> is indented with one tab (eight columns). The postimage changes them
> to use one tab per level.
Thanks for an easy-to-follow-concise-and-to-the-point review
summary. Very much appreciated.
>
> On Sat, Nov 2, 2024, at 17:53, Andrew Kreimer wrote:
>> Remove whitespace after redirect operator.
>>
>> Align mixed space/tab usages.
>>
>> Signed-off-by: Andrew Kreimer <algonell@xxxxxxxxx>
>> ...
>> + test_cmp ${name}_content5 ${name}_content6
>> + '
>
> Everything up to here looks like whitespace changes. Indeed.
>> + test_expect_success $PREREQ "Verify ${name}'s sha256 content" '
>> + git --git-dir=repo-sha256/.git cat-file ${type} ${sha256_oid}
>> >${name}_content7 &&
>> + git --git-dir=repo-sha1/.git cat-file ${type} ${sha1_sha256_oid}
>> >${name}_content8 &&
>> + test_cmp ${name}_content7 ${name}_content8
>> + '
>> }
>
> But this is diffed as an addition. Seems like either a mistake or the
> commit message and/or patch comment (`---`) didn’t mention this kind of
> change.
Good eyes. I suspect that it is from a separate topic, and this
patch is supposed to be preliminary clean-up for this change, or
something?
