Re: [External] Re: [PATCH v2 2/2] fetch-pack: warn if in commit graph but not obj db

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Han Xin <hanxin.hx@xxxxxxxxxxxxx> writes:
> Although the scenario I faked in t/t5330-no-lazy-fetch-with-commit-graph.sh
> usually does not occur, if we are unfortunate enough to encounter this issue,
> I hope it can automatically fix the problem as much as possible without
> relying on me to take an extra action.
> 
> Thanks.

Note that unfortunately the user will still need to take an extra
action.

My goal at first was to try to teach Git to fetch the commit (in the
commit graph file but not in the object DB) anyway, so that (as you
said) the problem will fix itself, but that requires not only a change
in the part of the code that emits "want", but also the part that emits
"have" (the fetch negotiation code). At that point, I decided that it's
better to stop early and warn the user (it was not a fatal error in the
original version of the code, but I have changed it).




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux