Taylor Blau <me@xxxxxxxxxxxx> writes: > On Thu, Oct 31, 2024 at 04:05:56PM -0400, Taylor Blau wrote: >> Hi Karthik, >> >> On Thu, Oct 31, 2024 at 10:39:43AM +0100, Karthik Nayak wrote: >> > Range-diff against v3: >> >> Skimming the range-diff, this new version looks good to me. It would be >> nice to hear from another reviewer or two before we start merging it >> down, but I think that this is looking good to me. > > Hmmph. I spoke too soon, this new version appears to break CI on > Windows, and thus broke the builds of 'jch' (and 'seen', by extension). > > https://github.com/ttaylorr/git/actions/runs/11602969593/job/32309061019 > > Can you have a look? > > In the meantime, I'm going to move this out of 'jch' to let CI run there > again. > Thanks for letting me know, I think the fix is simply diff --git a/packfile.c b/packfile.c index f626d38071..737cd60377 100644 --- a/packfile.c +++ b/packfile.c @@ -27,8 +27,8 @@ #include "pack-objects.h" struct packfile_config { - unsigned long packed_git_window_size; - unsigned long packed_git_limit; + unsigned long long packed_git_window_size; + unsigned long long packed_git_limit; }; #define PACKFILE_CONFIG_INIT \ Tested it on GitLab's CI too this time. https://gitlab.com/gitlab-org/git/-/jobs/8248707713 Will send in a new version including the fix tomorrow! Karthik
Attachment:
signature.asc
Description: PGP signature
