On 29/10/2024 14:58, Caleb White wrote:
On Tue Oct 29, 2024 at 9:52 AM CDT, Phillip Wood wrote:
Hi Caleb
On 28/10/2024 19:09, Caleb White wrote:
This patch expands the test coverage by adding cases that specifically
handle relative paths. These tests verify correct behavior in a variety
of operations, including: adding, listing, pruning, moving, and
repairing worktrees with relative paths configured.
This also adds a test case for reinitializing a repository that has
relative worktrees.
It's nice to see new tests being added. If they were added with the code
changes they test that would help reader understand the changes being
made I think.
I had received feedback that the original patch was too large, so I
was trying to split it up into smaller, more digestible pieces.
One way to do that would be to convert the "add", "move" and "repair"
subcommands in separate patches changing option handling and appropriate
tests in each one rather than changing all subcommands and their tests
at once.
Best Wishes
Phillip
I could
go either way so it's really what the reviewers would prefer.
Best,
Caleb
