On Mon, Oct 28, 2024 at 12:34:09PM -0700, Jonathan Tan wrote: > Taylor Blau <me@xxxxxxxxxxxx> writes: > > This patch appears to conflict with ds/path-walk, which wants to read > > the exclude_promisor_objects variable from outside of cmd_pack_objects() > > (but elsewhere within the builtin/pack-objects.c compilation unit). > > > > Is this refactoring a necessary step, or just cleanup? If the former, it > > may be good for you and Stolee (CC'd) to work together to figure out how > > to eliminate the conflict from your two series. If the latter, it may be > > worth dropping this patch. > > > > Thanks, > > Taylor > > It's just cleanup. I've dropped this patch in my local copy but will > wait for reviews before sending the next one (probably not worth sending > it now since it's a relatively trivial change). > > I've also looked briefly at ds/path-walk - will reply with a few > comments on that email thread. Great, thanks on both. Thanks, Taylor P.S.: it's good to see you back on the list again :-).
