On Mon, Oct 28, 2024 at 06:20:21AM +0000, Usman Akinyemi wrote: > On Mon, Oct 28, 2024 at 6:11 AM Patrick Steinhardt <ps@xxxxxx> wrote: > > > ---- December 23 - February 10: Incremental Conversions & Feedback > > > Integration ----- > > > > > > - File Renaming: Rename test files from t-<name>.c to <name>.c > > > following the structure outlined by prior contributions. > > > - Clar Suite Integration: Add the module name to CLAR_TEST_SUITE in > > > the Makefile to include the file in the Clar testing suite. > > > - Conversion of Test Assertions: Replace the test assertions with > > > Clar’s built-in functions (cl_assert, cl_assert_equal_s, > > > cl_assert_equal_i, etc.), enhancing readability and functionality. > > > - Patch Submission: Submit each converted test as an incremental > > > patch to Git's mailing list following the Git contribution guidelines. > > > This phased approach enables targeted feedback from the community. > > > > One thing missing here is the work with upstream in case we want to > > implement any functionality that doesn't yet exist in clar. You mention > > it in "Additional Goals and Extensions" though, so that might be good > > enough. > > > > Other than that this looks good to me, thanks! Please don't forget to > > upload your applications to Outreachy if you haven't done so already. > > > Hi, Patrick > Thanks for your review. > Will it be better to include *work with upstream* as part of the whole > timeline instead of adding it as an Additional Goals and Extensions? I don't mind it too much, and as mentioned elsewhere I think that it's perfectly fine if the timeline is rough. It's more about demonstrating that you're aware of the steps, which you seem to be. Patrick
