On Mon, Oct 21, 2024 at 05:43:48PM -0400, Taylor Blau wrote: > On Sun, Oct 20, 2024 at 01:43:13PM +0000, Derrick Stolee via GitGitGadget wrote: > > Updates in v2 > > ============= > > > > I'm sending this v2 to request some review feedback on the series. I'm sorry > > it's so long. > > > > There are two updates in this version: > > > > * Fixed a performance issue in the presence of many annotated tags. This is > > caught by p5313 when run on a repo with 10,000+ annotated tags. > > * The Scalar config was previously wrong and should be pack.usePathWalk, > > not push.usePathWalk. > > Thanks. I queued the new round. As an aside, I would like to find the > time to review this series in depth, but haven't been able to do so > while also trying to keep up with the volume of the rest of the list. > > I know that this topic was split out of a larger one. It may be worth > seeing if there is a way to split this topic out into multiple series > that are more easily review-able, but still sensible on their own. > > I haven't looked in enough depth to know myself whether such a cut > exists, but it is worth thinking about if you haven't done so already. I'm in the same boat -- I want to review this, but somehow never find the time to sit down and do it. I definitely won't get to it this week as I'll be out-of-office for most of the part. I've flagged this internally now at GitLab so that we can provide some more data with some of the repos that are on the bigger side to check whether we can confirm the findings and to prioritize its review. Patrick
