On Sun, Oct 27, 2024 at 07:48:35PM -0400, Taylor Blau wrote:
> It may be nice to write this as a switch statement, since we're always
> comparing the value of oflags & O_ACCMODE, like so:
>
> switch (oflags & O_ACCMODE) {
> case O_RDWR:
> access = GENERIC_READ | GENERIC_WRITE;
> break;
> case O_WRONLY:
> access = GENERIC_WRITE;
> break;
> default:
> access = GENERIC_READ;
> break;
> }
>
> , but it is a minor point and I certainly do not have very strong
> feelings here.
...and I see that's exactly what you went with in the subsequent round
;-).
Thanks,
Taylor
