Junio C Hamano wrote:
+ $fg_done = "true";
+ }
+ elsif ($word =~ /black|red|green|yellow/ ||
+ $word =~ /blue|magenta|cyan|white/) {
exists $color_name{$word}
with
my %color_name = map { $_ => 1 } qw(black red ... white);
at the beginning?
I don't see the advantage of doing it that way. After all, we're pattern
matching. Does using a hash, an array, and a call to map() gain us
something? I think a regular expression is clearer. Of course, as Jeff
pointed out, I should have used a whitespace-agnostic regular expression.
+ elsif ($word =~ /black|red|green|yellow|
+ blue|magenta|cyan|white/x ) {
I agreed with the rest of your suggestions, and will implement them in
the next round of changes, later this week.
Dan
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
