Am 24.10.24 um 13:46 schrieb Patrick Steinhardt: > Hi, > > this is the second patch series that implements POSIX-style atomic > renames on Windows in order to fix concurrent writes with the reftable > backend. > > Changes compared to v1: > > - Added some historic digging to the first commit message. > > - Fix various spelling mistakes. > > - Fix indentation. > > - Don't use the comma operator to assign `errno`. > > Thanks! > > Patrick Thank you for working on this. The patches look good in general, but I noticed that oflags handling in 2/3 needs to be fixed. I ran the test suite on my Windows 10 box with this series, and it passed all tests (with my suggested oflags fix applied). I also cross-checked whether I would observe the failure that the series attempts to fix, and I do see the failure, and the series fixes it. -- Hannes
