On 2024.10.16 10:12, Patrick Steinhardt wrote: > The iconv library is used by Git to reencode files, commit messages and > other things. As such it is a rather integral part, but given that many > platforms nowadays use UTF-8 everywhere you can live without support for > reencoding in many situations. It is thus optional to build Git with > iconv, and some of our platforms wired up in "config.mak.uname" disable > it. But while we support building without it, running our test suite > with "NO_ICONV=Yes" causes many test failures. > > Wire up a new test prerequisite ICONV that gets populated via our > GIT-BUILD-OPTIONS. Annotate failing tests accordingly. > > Note that this commit does not do a deep dive into every single test to > assess whether the failure is expected or not. Most of the tests do > smell like the expected kind of failure though. > > Signed-off-by: Patrick Steinhardt <ps@xxxxxx> > --- > diff --git a/t/t6006-rev-list-format.sh b/t/t6006-rev-list-format.sh > index f1623b1c06d..2a01a62a2f3 100755 > --- a/t/t6006-rev-list-format.sh > +++ b/t/t6006-rev-list-format.sh [snip] > @@ -198,7 +218,7 @@ Thu, 7 Apr 2005 15:13:13 -0700 > 1112911993 > EOF > > -test_format encoding %e <<EOF > +test_format ICONV encoding %e <<EOF > commit $head2 > $test_encoding > commit $head1 > @@ -374,7 +394,7 @@ test_expect_success 'setup complex body' ' > head3_short=$(git rev-parse --short $head3) > ' > > -test_format complex-encoding %e <<EOF > +test_format ICONV complex-encoding %e <<EOF > commit $head3 > $test_encoding > commit $head2 > diff --git a/t/t7102-reset.sh b/t/t7102-reset.sh > index 2add26d7684..e9a6cc72658 100755 > --- a/t/t7102-reset.sh > +++ b/t/t7102-reset.sh These two changes subtly break t6006 (in such a way that it still passes, but is clearly not testing what we want): ./t6006-rev-list-format.sh: line 92: test_expect_%e: command not found
