Re: [PATCH v3 4/6] transport: add client support for object-info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 23, 2024 at 5:48 AM Christian Couder
<christian.couder@xxxxxxxxx> wrote:
>
> On Thu, Sep 26, 2024 at 3:39 AM Eric Ju <eric.peijian@xxxxxxxxx> wrote:
>
> > +       if (transport->smart_options
> > +               && transport->smart_options->object_info
> > +               && transport->smart_options->object_info_oids->nr > 0) {
> > +               struct ref *ref_itr = object_info_refs = alloc_ref("");
> > +
> > +               if (!fetch_object_info(transport, data->options.object_info_data))
> > +                       goto cleanup;
> > +
> > +               args.object_info_data = data->options.object_info_data;
> > +               args.quiet = 1;
> > +               args.no_progress = 1;
> > +               for (size_t i = 0; i < transport->smart_options->object_info_oids->nr; i++) {
> > +                       ref_itr->old_oid = transport->smart_options->object_info_oids->oid[i];
> > +                       ref_itr->exact_oid = 1;
> > +                       if (i == transport->smart_options->object_info_oids->nr - 1)
> > +                               /* last element, no need to allocate to next */
> > +                               ref_itr -> next = NULL;
>
> Space characters should be removed around "->".

Thank you. It is fixed in v4.



>
> > +                       else
> > +                               ref_itr->next = alloc_ref("");
>
> Here for example there are no spaces around "->".





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux