On 10/21/24 5:43 PM, Taylor Blau wrote:
On Sun, Oct 20, 2024 at 01:43:13PM +0000, Derrick Stolee via GitGitGadget wrote:Updates in v2 ============= I'm sending this v2 to request some review feedback on the series. I'm sorry it's so long. There are two updates in this version: * Fixed a performance issue in the presence of many annotated tags. This is caught by p5313 when run on a repo with 10,000+ annotated tags. * The Scalar config was previously wrong and should be pack.usePathWalk, not push.usePathWalk.Thanks. I queued the new round. As an aside, I would like to find the time to review this series in depth, but haven't been able to do so while also trying to keep up with the volume of the rest of the list. I know that this topic was split out of a larger one. It may be worth seeing if there is a way to split this topic out into multiple series that are more easily review-able, but still sensible on their own.
I'll see what I can do. I needed to re-roll after discovering an issue when trying to integrate the algorithm with shallow clones. The solution ends up simplifying the code, which is nice.
I haven't looked in enough depth to know myself whether such a cut exists, but it is worth thinking about if you haven't done so already.
In the current series, there's a natural cut between patches 1-4 and the rest, if we want to put the API in without a non-test consumer. I could also split out the 'git repack' changes into a third series. Finally, the threading implementation could be done separately, but I think it's not complicated enough to leave out from the first version of the --path-walk option in 'git pack-objects'. Thanks, -Stolee
