On Wed, Oct 23, 2024 at 08:00:53PM +0200, Kristoffer Haugsbakk wrote: > All of the changes here look good. Same, modulo the one comment below where I think the grammar is still wrong. Thanks, Andrew, for working on this, and to Kristoffer for reviewing. > > […] > > diff --git a/t/t5528-push-default.sh b/t/t5528-push-default.sh > > index bc2bada34c..aecd03d69f 100755 > > --- a/t/t5528-push-default.sh > > +++ b/t/t5528-push-default.sh > > @@ -147,7 +147,7 @@ test_expect_success 'push from/to new branch fails > > with upstream and simple ' ' > > # - the default push succeeds > > # > > # A previous test expected this to fail, but for the wrong reasons: > > -# it expected a fail becaause the branch is new and cannot be pushed, > > but > > +# it expected a fail because the branch is new and cannot be pushed, > > Also: s/a fail/a failure/ ? > > Perhaps “to fail”. Yeah, I think "to fail" is what was supposed to be written her, but "a failure" would also be acceptable. Thanks, Taylor
