On Mon, Oct 21, 2024 at 10:38:02AM -0500, karthik nayak wrote:
> shejialuo <shejialuo@xxxxxxxxx> writes:
>
> [snip]
>
> > diff --git a/t/t0602-reffiles-fsck.sh b/t/t0602-reffiles-fsck.sh
> > index 71a4d1a5ae..0aee377439 100755
> > --- a/t/t0602-reffiles-fsck.sh
> > +++ b/t/t0602-reffiles-fsck.sh
> > @@ -25,6 +25,13 @@ test_expect_success 'ref name should be checked' '
> > git tag tag-2 &&
> > git tag multi_hierarchy/tag-2 &&
> >
> > + cp $branch_dir_prefix/branch-1 $branch_dir_prefix/@ &&
> > + git refs verify 2>err &&
> > + cat >expect <<-EOF &&
> > + EOF
> > + test_must_be_empty err &&
> > + rm $branch_dir_prefix/@ &&
> > +
> > cp $branch_dir_prefix/branch-1 $branch_dir_prefix/.branch-1 &&
> > test_must_fail git refs verify 2>err &&
> > cat >expect <<-EOF &&
> > @@ -33,20 +40,20 @@ test_expect_success 'ref name should be checked' '
> > rm $branch_dir_prefix/.branch-1 &&
> > test_cmp expect err &&
> >
> > - cp $branch_dir_prefix/branch-1 $branch_dir_prefix/@ &&
> > + cp $branch_dir_prefix/branch-1 $branch_dir_prefix/'\'' branch-1'\'' &&
>
> Nit: Here and below we could use ${SQ} instead.
>
I agree.
> [snip]
