On Mon, Oct 21, 2024 at 11:57:45AM +0200, Karthik Nayak wrote: > The function `unuse_one_window` currently relies on the global variable > `the_repository`. To eliminate global variable usage in `packfile.c`, we > should progressively shift the dependency on the_repository to higher > layers. Let's remove its usage from this function and any related ones. > > Signed-off-by: Karthik Nayak <karthik.188@xxxxxxxxx> > --- > builtin/pack-objects.c | 12 ++++++------ > pack-check.c | 6 +++--- > packfile.c | 25 +++++++++++++------------ > packfile.h | 3 ++- > streaming.c | 2 +- > 5 files changed, 25 insertions(+), 23 deletions(-) All looks correct, as unuse_one_window() already uses the_repository, so I don't think any behavior is changed here... Thanks, Taylor
