Re: [BUG] fast-import producing very deep tree deltas

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon, 12 Nov 2007, Brian Downing wrote:
> 
>     depths: count 135970 total 120567366 min 0 max 6035 mean 886.72 median 3 std_dev 1653.48
> 
> Needless to say the pack that resulted was just about useless.  Trying to
> repack it resulted in the "counting objects" phase running at about five
> objects per second.

Hmm. Quick hack: increase the delta cache window. The reason (I think) why 
performance turns glacial with really deep delta chains is that it turns 
into an O(n^2) thing when you don't hit in the delta cache, and your delta 
depth is so deep that following a *single* delta chain will flush the 
cache.

So I bet that making the delta cache bigger will "fix" it. You probably 
don't have to make it 6000+ entries, but with the *median* being that 
deep, making it 2k entries should improve it for most cases.

Obviously fastimport should be fixed to not do those insanely deep chains 
too, but it might be a good idea to at least make the delta cache a bit 
bigger by default, and perhaps have some config option for setting it.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux