Re: [PATCH v2] ref-filter: format iteratively with lexicographic refname sorting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 21, 2024 at 01:10:44PM +0200, Toon Claes wrote:
> Patrick Steinhardt <ps@xxxxxx> writes:
> > @@ -3258,7 +3279,6 @@ static inline int can_do_iterative_format(struct ref_filter *filter,
> >  	 */
> >  	return !(filter->reachable_from ||
> >  		 filter->unreachable_from ||
> > -		 sorting ||
> 
> Just a small nit, because we remove `sorting` from this condition, I
> suggest to also remove the following comment above it:
> 
> 	 * - sorting the filtered results
> 
> 
> Otherwise no comments from my side.

Ah, true. Will fix in v3, thanks!

Patrick




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux