Make changes to functions in 'packfile.c' to stop using the global
'the_hash_algo'. This requires changing some of the functions to accept
a repository variable and to modify layers above to pass this variable.
Signed-off-by: Karthik Nayak <karthik.188@xxxxxxxxx>
---
object-name.c | 4 ++--
pack-bitmap.c | 2 +-
packfile.c | 29 ++++++++++++++++++-----------
packfile.h | 3 ++-
4 files changed, 23 insertions(+), 15 deletions(-)
diff --git a/object-name.c b/object-name.c
index 368242133a..83a36915d6 100644
--- a/object-name.c
+++ b/object-name.c
@@ -179,7 +179,7 @@ static void unique_in_pack(struct packed_git *p,
return;
num = p->num_objects;
- bsearch_pack(&ds->bin_pfx, p, &first);
+ bsearch_pack(ds->repo, &ds->bin_pfx, p, &first);
/*
* At this point, "first" is the location of the lowest object
@@ -766,7 +766,7 @@ static void find_abbrev_len_for_pack(struct packed_git *p,
num = p->num_objects;
mad_oid = mad->oid;
- match = bsearch_pack(mad_oid, p, &first);
+ match = bsearch_pack(mad->repo, mad_oid, p, &first);
/*
* first is now the position in the packfile where we would insert
diff --git a/pack-bitmap.c b/pack-bitmap.c
index 97237acb24..da2fc45f3f 100644
--- a/pack-bitmap.c
+++ b/pack-bitmap.c
@@ -741,7 +741,7 @@ static uint32_t bitmap_bsearch_pos(struct bitmap_index *bitmap_git,
if (bitmap_is_midx(bitmap_git))
found = bsearch_midx(oid, bitmap_git->midx, result);
else
- found = bsearch_pack(oid, bitmap_git->pack, result);
+ found = bsearch_pack(the_repository, oid, bitmap_git->pack, result);
return found;
}
diff --git a/packfile.c b/packfile.c
index b0147231cb..e06931154f 100644
--- a/packfile.c
+++ b/packfile.c
@@ -30,7 +30,7 @@ char *odb_pack_name(struct repository *repo, struct strbuf *buf,
{
strbuf_reset(buf);
strbuf_addf(buf, "%s/pack/pack-%s.%s", repo_get_object_directory(repo),
- hash_to_hex(hash), ext);
+ hash_to_hex_algop(hash, repo->hash_algo), ext);
return buf->buf;
}
@@ -544,7 +544,7 @@ static int open_packed_git_1(struct repository *repo, struct packed_git *p)
unsigned char hash[GIT_MAX_RAWSZ];
unsigned char *idx_hash;
ssize_t read_result;
- const unsigned hashsz = the_hash_algo->rawsz;
+ const unsigned hashsz = repo->hash_algo->rawsz;
if (open_pack_index(repo, p))
return error("packfile %s index unavailable", p->pack_name);
@@ -614,7 +614,8 @@ static int open_packed_git(struct repository *repo, struct packed_git *p)
return -1;
}
-static int in_window(struct pack_window *win, off_t offset)
+static int in_window(struct repository *repo, struct pack_window *win,
+ off_t offset)
{
/* We must promise at least one full hash after the
* offset is available from this window, otherwise the offset
@@ -624,7 +625,7 @@ static int in_window(struct pack_window *win, off_t offset)
*/
off_t win_off = win->offset;
return win_off <= offset
- && (offset + the_hash_algo->rawsz) <= (win_off + win->len);
+ && (offset + repo->hash_algo->rawsz) <= (win_off + win->len);
}
unsigned char *use_pack(struct repository *repo, struct packed_git *p,
@@ -640,16 +641,16 @@ unsigned char *use_pack(struct repository *repo, struct packed_git *p,
*/
if (!p->pack_size && p->pack_fd == -1 && open_packed_git(repo, p))
die("packfile %s cannot be accessed", p->pack_name);
- if (offset > (p->pack_size - the_hash_algo->rawsz))
+ if (offset > (p->pack_size - repo->hash_algo->rawsz))
die("offset beyond end of packfile (truncated pack?)");
if (offset < 0)
die(_("offset before end of packfile (broken .idx?)"));
- if (!win || !in_window(win, offset)) {
+ if (!win || !in_window(repo, win, offset)) {
if (win)
win->inuse_cnt--;
for (win = p->windows; win; win = win->next) {
- if (in_window(win, offset))
+ if (in_window(repo, win, offset))
break;
}
if (!win) {
@@ -714,6 +715,7 @@ struct packed_git *add_packed_git(struct repository *repo, const char *path,
struct stat st;
size_t alloc;
struct packed_git *p;
+ struct object_id oid;
/*
* Make sure a corresponding .pack file exists and that
@@ -755,8 +757,12 @@ struct packed_git *add_packed_git(struct repository *repo, const char *path,
p->pack_local = local;
p->mtime = st.st_mtime;
if (path_len < repo->hash_algo->hexsz ||
- get_hash_hex(path + path_len - repo->hash_algo->hexsz, p->hash))
+ get_oid_hex_algop(path + path_len - repo->hash_algo->hexsz, &oid,
+ repo->hash_algo))
hashclr(p->hash, repo->hash_algo);
+ else
+ memcpy(p->hash, oid.hash, repo->hash_algo->rawsz);
+
return p;
}
@@ -1895,11 +1901,12 @@ void *unpack_entry(struct repository *r, struct packed_git *p, off_t obj_offset,
return data;
}
-int bsearch_pack(const struct object_id *oid, const struct packed_git *p, uint32_t *result)
+int bsearch_pack(struct repository *repo, const struct object_id *oid,
+ const struct packed_git *p, uint32_t *result)
{
const unsigned char *index_fanout = p->index_data;
const unsigned char *index_lookup;
- const unsigned int hashsz = the_hash_algo->rawsz;
+ const unsigned int hashsz = repo->hash_algo->rawsz;
int index_lookup_width;
if (!index_fanout)
@@ -1990,7 +1997,7 @@ off_t find_pack_entry_one(struct repository *repo, const unsigned char *sha1,
}
hashcpy(oid.hash, sha1, repo->hash_algo);
- if (bsearch_pack(&oid, p, &result))
+ if (bsearch_pack(repo, &oid, p, &result))
return nth_packed_object_offset(p, result);
return 0;
}
diff --git a/packfile.h b/packfile.h
index 98ec3616b4..d145959480 100644
--- a/packfile.h
+++ b/packfile.h
@@ -145,7 +145,8 @@ void check_pack_index_ptr(const struct packed_git *p, const void *ptr);
*
* See 'bsearch_hash' for more information.
*/
-int bsearch_pack(const struct object_id *oid, const struct packed_git *p, uint32_t *result);
+int bsearch_pack(struct repository *repo, const struct object_id *oid,
+ const struct packed_git *p, uint32_t *result);
/*
* Write the oid of the nth object within the specified packfile into the first
--
2.47.0
