On Fri, 18 Oct 2024 at 22:03, Taylor Blau <me@xxxxxxxxxxxx> wrote: > > On Fri, Oct 18, 2024 at 10:04:43PM +0200, Kristoffer Haugsbakk wrote: >> We can see that from the patch. Saying what it does is redundant in >> this case in my opinion. :) >> I think it suffices to say that you are fixing the code style. If so >> this would have been enough: >> You seem to be wrapping the lines at 80 columns. 72 columns is more >> common here. The idea is (I think) that you add some slack for things >> like commit message indentation in git-log(1), multiple levels of email >> quoting and so on. >> It’s kind of indirectly mentioned in Documentation/MyFirstContribution. >> I also found this: >> https://lore.kernel.org/git/ZrCdDHqKfwWbr_Zn@tanuki/ Duly noted, haha! > > Hiya > > > > > [[PATCH][Outreachy]] > > > > Apparently you can’t nest brackets like this according to git-am(1). I > > got this: > > > > ] t7011-skip-worktree-reading.sh: ensure no whitespace after redirect operators > > > > Doesn’t really matter though. I suspect `[PATCH Outreachy]` would work. > > Indeed. With format-patch, you can do '--rfc=-Outreachy' to achieve the > desired effect. Thank you for the feedback Kristoffer and Taylor! I'll adjust the subject line to conform to git-am using Taylor's suggestion for my next patch :) > > > The diff here is clean. It only does what you describe in the commit > > message. Good. > > > > I checked the file and I can’t find any missed instances. Nice! > > Thanks for the helpful review and feedback for Seyi's patch. > > Seyi: I'll queue this into my tree, but mark it as expecting a new > version to address Kristoffer's comments above. Thanks. > > Thanks, > Taylor Duly noted, Thanks.
