Re: [PATCH v2 0/3] parse: replace atoi() with strtoul_ui() and strtol_i()

Taylor Blau <me@xxxxxxxxxxxx> · Fri, 18 Oct 2024 17:35:58 -0400

On Fri, Oct 18, 2024 at 09:29:44PM +0000, Usman Akinyemi wrote:
> On Fri, Oct 18, 2024 at 9:22 PM Taylor Blau <me@xxxxxxxxxxxx> wrote:
> >
> > On Fri, Oct 18, 2024 at 01:52:57PM +0000, Usman Akinyemi via GitGitGadget wrote:
> > > Changes from Version 1:
> > >
> > >  * In my initial commit, I mistakenly included changes from a different
> > >    patch and commit. This issue has now been resolved.
> >
> > Should we treat this as a new series, then? Or is this a true reroll of
> > the previous round and should be kept together?
> Hello Taylor,
> Yeah, this should be treated as a new series different from the two below.
>  - t3404: replace test with test_line_count()
>  - t3404: avoid losing exit status with focus on `git show` and `git cat-file`

Gotcha. So in the original ua/t3404-cleanup series from my tree, I
should drop the third and final patch:

  parse: replace atoi() with strtoul_ui() and strtol_i()

?

Thanks,
Taylor