On Thu, Oct 17, 2024 at 12:31:26PM -0400, Eric Sunshine wrote: > On Thu, Oct 17, 2024 at 11:30 AM Kristoffer Haugsbakk > <kristofferhaugsbakk@xxxxxxxxxxxx> wrote: > > On Thu, Oct 17, 2024, at 00:09, Taylor Blau wrote: > > > On Wed, Oct 16, 2024 at 06:08:05PM -0400, Eric Sunshine wrote: > > >> I think we typically avoid rewrapping after minor edits like this > > >> since rewrapping introduces unnecessary noise which makes it more > > >> difficult for reviewers to identify the important (actual) change. > > > > I was skeptical at first. But I saw that this line is only 55 > > characters long. So I think (like Taylor) that rewrap is in order. > > > > What if I make a commit with just that word drop and then an immediate > > fixup! commit which wraps the paragraph? That way the review is still > > straightforward. And hopefully the integration part is not complicated > > further. > > Don't bother. That's even more work for yourself, for reviewers, and > for the integrator, and it increases the cognitive load for everyone. > > There are far fewer reviewers than there are people submitting patches > to this project, so it is helpful for submitters to do what they can > to make life easier for reviewers, and foregoing re-wrapping of lines, > in general, is one such way to do so. However, this is such a minor > change that it isn't going to matter one way or the other, especially > if Taylor, as interim maintainer, is willing to accept the extra noise > caused by re-wrapping. I agree with everything Eric wrote here. If you want to send a new round that re-wraps the text, please do so in this patch (that is, make patch 1/6 in your new round apply the changes from this version *and* rewrap the containing paragraph). Please do not send fixup! patches or other such things. Thanks, Taylor
