On Nov 12, 2007 11:59 PM, Johannes Sixt <j.sixt@xxxxxxxxxxxxx> wrote: > But at this time git-commit is about to be made a builtin, and since your > implementation contains a lot of non-portable constructs ($'', >&) and a new > dependency on awk (and, hence, has little chances of being accepted), I > suggest that you stay tuned, and implement this in the forth-coming > builtin-commit.c. Implement this in shell scripts is just a piece of cake, but not so easy in builtin-commit.c. Not to mention that i'm unamiliar with git c code. $', >& portable problem can be easily corrected. However, awk is a new dependency? I have seen it in git-mergetool.sh > > > A configuration variable 'submodule.status' is used to turn this summary > > behaviour on or off (default off). Also --submodule and --no-submodule options > > are added. > > There is already 'status.color', I suggest the configuration to become > 'status.submoduleSummary'. There is 'status.color', but 'color.status' is prefered as said in the documentation. So i follows this rule, name the variable submodule.* just as the ones for git-submodule. I think it's a good idea to put all submodule related configuration variables in the submodule.* namespaces. > > -- Hannes > > -- Ping Yin - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
