On 16/10/2024 10:03, Phillip Wood wrote:
I'm pretty sure I've used "git -c core.hookspath=/dev/null ..."
Looking at the code that will unfortunately disable all hooks including
the ones in .git/hooks. It would make sense to allow an empty
core.hooksPath mean "use .git/hooks". If you're interested in working
on this then I think doing something like
diff --git a/config.c b/config.c
index a11bb85da30..91f190a1ce1 100644
--- a/config.c
+++ b/config.c
@@ -1437,7 +1437,10 @@ static int git_default_core_config(const char *var, const char *value,
if (!strcmp(var, "core.hookspath")) {
FREE_AND_NULL(git_hooks_path);
- return git_config_pathname(&git_hooks_path, var, value);
+ if (value)
+ return git_config_pathname(&git_hooks_path, var, value);
+ else
+ return 0;
}
if (!strcmp(var, "core.bare")) {
would be a good starting point
Best Wishes
Phillip
in the
past when I've wanted to temporarily disable my hooks path, I can't find
anything in the documentation though. If
git config core.hookspath /dev/null
does work for you it would be really helpful to update the documentation.
Best Wishes
Phillip
I would be happy to code a patch for this if I knew how it should be
configured. Obviously, no local setting for a config variable is meant
to inherit the global or system value. We can go all "set of the null
set" by making the empty string mean "revert to default". We could go
fancy "I know what you really mean" by interpreting ".git/hooks" (or
perhaps any path beginning with ".git") not literally in the case of
worktrees, but as relative to GIT_DIR. Or there could be another
setting set on a local repository to ignore global and system values of
core.hooksPath.
Thank you,
Sam Newbold
