Kyle Lippincott <spectral@xxxxxxxxxx> writes: > On Fri, Oct 11, 2024 at 6:50 PM Karthik Nayak <karthik.188@xxxxxxxxx> wrote: >> >> We enforce alignment of expressions after linebreaks. Which means for >> code such as >> >> return a || b; >> >> it will expect: >> >> return a || >> b; >> >> we instead want 'b' to be indent with tabs, which is already done by the >> 'ContinuationIndentWidth' variable. > > Why do we want `b` to be indented by 8 columns instead of aligned? I > think this is harder to read: > > int some_int_variable = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa + > bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; > The reason I added this is because by default editors will follow the '.editorconfig' and follow the 'tab_width = 8' rule when there is a line break. This means more often than not, most patches don't follow this rule. We don't enforce clang-format at this point so it makes more sense to align the rule to what everyone is doing. The goal being that once we have a good set of base rules with less false positives, we can start enforcing. > Of course, this is even better, if it fits in 80 cols: > > int some_int_variable = > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa + bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; > I'm sure we can tweak this with penalties ;) But I'd say this is something we can tune later.
Attachment:
signature.asc
Description: PGP signature
