On 2024.10.08 16:45, Junio C Hamano wrote: > Josh Steadmon <steadmon@xxxxxxxxxx> writes: > > > Add environment variable, INCLUDE_LIBGIT_RS, that when set, > > automatically builds and tests libgit-rs and libgit-rs-sys when `make > > all` is ran. > > Is this unusual, or is it just like how other makefile macros like > say USE_NSEC (to cause the resulting Git to use subsecond mtimes) > are meant to be used to control the build? IOW, shouldn't this be > documented near the top of the Makefile, e.g. > > diff --git i/Makefile w/Makefile > index 41ad458aef..2b55fe9672 100644 > --- i/Makefile > +++ w/Makefile > @@ -392,6 +392,9 @@ include shared.mak > # INSTALL_STRIP can be set to "-s" to strip binaries during installation, > # if your $(INSTALL) command supports the option. > # > +# Define INCLUDE_LIBGIT_RS if you want your gostak to distim > +# the doshes and ... > +# > # Define GENERATE_COMPILATION_DATABASE to "yes" to generate JSON compilation > # database entries during compilation if your compiler supports it, using the > # `-MJ` flag. The JSON entries will be placed in the `compile_commands/` > > It might make sense to follow naming convention to call it NO_RUST > and flip its polarity. Those who do not have or want libgit-rs and > friends can say NO_RUST but otherwise it gets built by default. It > would give you a wider developer population coverage. > > Thanks. For now I'd be more comfortable keeping it off by default. I don't want to force those not interested in Rust to work around our in-progress projects. Once it's more stable and we have CI I'd feel better about turning it on by default (and maybe moving it out of contrib/ at that point?).
