Re: [PATCH 00/10] reftable: stop using `struct strbuf`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Patrick Steinhardt <ps@xxxxxx> writes:

> Hi,
>
> this is the second patch series on my quest to make the reftable library
> become a standalone library again that can be used by libgit2 without
> pulling in all kinds of dependencies from the Git codebase. This part
> makes us lose the dependency on `struct strbuf`, which is done due to
> three reasons:
>
>   - To make us independent of libgit.a.
>
>   - To ensure that we use the pluggable allocators that users can set up
>     via `reftable_set_alloc()`.
>
>   - To make it possible to handle memory allocation failures.
>
> While this leads to some duplication, we're only talking about ~70 lines
> of code.
>

I only have a few small comments, but overall this series looks good.
Thanks

[snip]

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux