On 2024-10-10 at 18:24:52, Alejandro R. Sedeño wrote: > As of ad9bb6dfe6e598d87ffe6e2285b4b86dac3bc726, http.c depends on > symbols introduced curl 7.37.0, which is newer than the documented > minimum version of 7.21.3 in INSTALL. > > ``` > In file included from /usr/include/curl/curl.h:2238:0, > from git-curl-compat.h:3, > from http.c:4: > http.c: In function ‘set_proxyauth_name_password’: > http.c:655:28: error: ‘CURLOPT_PROXYHEADER’ undeclared (first use in > this function) > curl_easy_setopt(result, CURLOPT_PROXYHEADER, > ^ > http.c:655:28: note: each undeclared identifier is reported only once > for each function it appears in > make: *** [http.o] Error 1 > ``` From the curl changelog, I do agree that that feature was added in 7.37.0. I think that's okay, since that was released in May 2014, over a decade ago, so we probably need to update INSTALL appropriately. I don't think any major Linux distros are still offering complementary security support for such an old version of libcurl, so I don't see us restoring support for older libcurl. It will probably also involve ripping out appropriate parts of `git-curl-compat.h` and the option flags. If nobody else gets to it over the next couple of days, I'll try to, but of course anyone is free to send in a patch. -- brian m. carlson (they/them or he/him) Toronto, Ontario, CA
Attachment:
signature.asc
Description: PGP signature
