On Thu, Oct 10, 2024 at 06:54:53AM +0200, Patrick Steinhardt wrote: > On Wed, Oct 09, 2024 at 04:14:38PM -0700, Junio C Hamano wrote: > > Junio C Hamano <gitster@xxxxxxxxx> writes: > > > > > Patrick Steinhardt <ps@xxxxxx> writes: > > > > > >> Fix the regression by again unconditionally allocating the value in the > > >> `out` parameter, if provided. Add a test that unsets the environment > > >> variable to catch future regressions in this area. > > >> > > >> Reported-by: Shubham Kanodia <shubham.kanodia10@xxxxxxxxx> > > >> Signed-off-by: Patrick Steinhardt <ps@xxxxxx> > > >> --- > > > > > > Thanks for quickly reporting and addressing this one, both of you. > > > > > > Will queue. > > > > We seem to be getting: > > > > git maintenance start --scheduler=systemd > > D:/a/git/git/git.exe: error while loading shared libraries: ?: cannot open shared object file: No such file or directory > > > > https://github.com/git/git/actions/runs/11264159690/job/31323795058#step:5:327 > > Oh well. Lucky me that I'm spending half of my life in Windows VMs now > anyway, so I'll have a look. > > Patrick Ah, the difference between `pwd` and `$PWD` strikes again: the former uses Windows-style paths, the latter uses Cygwin-style ones. And as the Windows-style path contains a colon the resulting PATH variable was broken. Will send v3 in a bit, thanks! Patrick
