On Wed, Oct 9, 2024 at 8:20 AM Patrick Steinhardt <ps@xxxxxx> wrote: > > On Wed, Oct 09, 2024 at 04:35:04AM +0100, Samuel Abraham wrote: > > On Tue, Oct 8, 2024 at 7:13 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > > > > > Samuel Abraham <abrahamadekunle50@xxxxxxxxx> writes: > > > > > > > ... > > > > This was the reason for replacing "test ! -[df]" with > > > > "test_path_is_missing" where I think is appropriate. > > > > > > Telling that concisely in the proposed log message will help those > > > who are reviewing the patch and those who are reading "git log -p" > > > later, and that is what I would want to see after a review exchange > > > like this. > > > > > > Thanks. > > Hi, Junio > > I want to express my gratitude to you and every member for your time, > > guidance and patience and to my Outreachy mentors Patrick and Phillip. > > It has been a great learning experience. I can see the patch has been > > integrated into seen. > > I look forward to working on #leftoverbits projects to enhance my understanding > > of the git codebase. Thank you very much once again. > > Note that a patch that has been merged into "seen" does not yet say that > it will be part of the next release. "seen" is only an integration > branch for topics which are currently in-flight on the mailing list and > in the process of being reviewed. The intent is that we can catch any > incompatibilities between two different in-flight patch series early. > > So declaring victory is a bit too early :) A better indicator is that > the patch has been merged to "next". This is described in > Documentation/MyFirstContribution.txt, section "After Review Approval", > and more in-depth in Documentation/howto/maintain-git.txt. > > I think that your v2 isn't quite there yet. As Junio mentions, he'd like > to see an updated commit message that includes your explanations why you > have done certain conversions the way you did. The fact that some parts > of the patch required discussion to arrive at a common understanding is > a good telling factor that a summarized form of the discussion should > likely be part of the commit message such that future readers of the > patch will get the same context. > > Patrick Hello Patrick, Thank you very much for the clarification. Yes I was almost celebrating already :). I will write a detailed commit message and send an updated patch. Thanks.
