On Mon, Oct 7, 2024 at 7:58 AM Phillip Wood <phillip.wood123@xxxxxxxxx> wrote: > > Hi Kristoffer > > On 07/10/2024 12:10, Kristoffer Haugsbakk wrote: > > From: Kristoffer Haugsbakk <kristofferhaugsbakk@xxxxxxxxxxxx> > > > > From: Kristoffer Haugsbakk <code@xxxxxxxxxxxxxxx> > > > > This is easier to read. > > I think that is a matter of taste, one could argue that using uppercase > variable names makes them stand out so the user can see which arguments > are parameters more clearly. Yeah, I wrote it as uppercase because I thought that was easier to read for the reasons Phillip gives. It's not a strong preference, but I do think the commit message needs a more detailed rationale or link to an agreed project coding style or something, otherwise the commit message may appear to be false to half the readers.
