On Mon, Oct 07, 2024 at 08:58:40AM +0200, Patrick Steinhardt wrote: > On Sun, Sep 29, 2024 at 03:17:01PM +0800, shejialuo wrote: > > We do allow users to use "git symbolic-ref" to create symrefs which > > point to one of the linked worktrees from the primary worktree or one of > > the linked worktrees. > > > > We should not info the user about the escape for above situation. So, > > enhance "files_fsck_symref_target" function to check whether the "referent" > > starts with the "worktrees/" to make sure that we won't warn the user > > when symrefs point to "referent" in the linked worktrees. > > Shouldn't this commit be squashed into the former one, as it immediately > fixes an edge case that was introduced with the parent commit? > I partially agree here. I don't think this is an edge case that was introduced with the parent commit. The reason why I use a new commit here is that I want to emphasis the behavior. This is because Junio asked me in the v4 about "escapeReferent" I am not sure starting this as ERROR is wise. Users and third-party tools make creative uses of the system and I cannot offhand think of an argument why it should be forbidden to create a symbolic link to our own HEAD or to some worktree-specific ref in another worktree. Actually, I have never thought we could do this. So, this is my intention. But I do agree that this commit is highly relevant with the parent commit. I will improve this in the next version. > Patrick
