On Mon, Oct 7, 2024 at 6:05 AM Patrick Steinhardt <ps@xxxxxx> wrote: > > On Sun, Oct 06, 2024 at 04:06:09PM +0000, Usman Akinyemi via GitGitGadget wrote: > > @@ -401,8 +402,8 @@ test_expect_success 'multi-squash only fires up editor once' ' > > ) && > > test $base = $(git rev-parse HEAD^) && > > git show >output && > > - count=$(grep ONCE output | wc -l) && > > - test 1 = $count > > + grep ONCE output >actual && > > + test_line_count = 1 actual > > ' > > > > test_expect_success 'multi-fixup does not fire up editor' ' > > Oh, you already do the change I proposed on the first commit. It's a bit > funny that we first change things one way and then touch it up again in > another commit as it leaves the reviewer wondering for a bit. > > But I guess that's okay, especially for a microproject. So overall I > don't see a strong reason to reroll this series, thanks! > > Patrick Thank you very much for the review. I really appreciate it. I had to make this separate commit as recommended in the resources you provided and reviews from other reviewers.
