Thanks for this. I will definitely take note of this next time. Thank you. On Sun, Oct 6, 2024 at 4:21 PM Kristoffer Haugsbakk <kristofferhaugsbakk@xxxxxxxxxxxx> wrote: > > On Sun, Oct 6, 2024, at 18:06, Usman Akinyemi via GitGitGadget wrote: > > > > The root cause of the whitespace issue was quoting $count in the test > > command, which led to the inclusion of whitespace in the comparison. By > > removing the quotes around $count, the comparison works as expected without > > the need for tr -d. > > > > Signed-off-by: Usman Akinyemi > > > > Usman Akinyemi (2): > > t3404: avoid losing exit status with focus on `git show` and `git > > cat-files` > > [Outreachy][Patch v1] t3404: employing test_line_count() to replace > > test > > You don’t have to sign off on your cover letter. Just the patches. :) > > Of course do what you prefer.