On Sun, Oct 6, 2024, at 17:09, shejialuo wrote: > On Sun, Oct 06, 2024 at 06:00:57AM +0000, Caleb White wrote: >> This refactors the `infer_backlink` function to return an integer >> result and use a pre-allocated `strbuf` for the inferred backlink >> path, replacing the previous `char*` return type. >> >> This lays the groundwork for the next patch, which needs the >> resultant backlink as a `strbuf`. There was no need to go from >> `strbuf -> char* -> strbuf` again. This change also aligns the >> function's signature with other `strbuf`-based functions. >> > > I think we should first say why we need to add the change in the commit > message which means we should express our motivation in the first. It's > wired to say "I have done something" and then talk about the motivation > why we do this. > >> Signed-off-by: Caleb White <cdwhite3@xxxxx> >> --- >> worktree.c | 26 ++++++++++++++------------ >> 1 file changed, 14 insertions(+), 12 deletions(-) >> >> diff --git a/worktree.c b/worktree.c >> index 0f032cc..c6d2ede 100644 >> --- a/worktree.c >> +++ b/worktree.c >> @@ -642,10 +642,9 @@ static int is_main_worktree_path(const char *path) >> * be able to infer the gitdir by manually reading /path/to/worktree/.git, >> * extracting the <id>, and checking if <repo>/worktrees/<id> exists. >> */ >> -static char *infer_backlink(const char *gitfile) >> +static int infer_backlink(st >> ruct strbuf *inferred, const char *gitfile) > > This line is so strange. Why it generates a newline here? The patches got corrupted by something. See the emails from Eric Sunshine. This resubmit didn’t fix the issue. https://lore.kernel.org/git/CAPig+cTB-sA-g4cdhfEjWwY1mnbWJ41e=bOCNwp=Y8JKvpmpRg@xxxxxxxxxxxxxx/ -- Kristoffer Haugsbakk
