On Sun, Oct 06, 2024 at 05:19:13AM -0400, Eric Sunshine wrote: [snip] > It probably would have been helpful to reviewers if the patch's > commit message mentioned that it only converts some of the > instances, but it's not worth rerolling the patch just for that. Except that, the commit title should not either include "[Outreachy][Patch v1]" here. From these two reasons, I think we should reroll the patch. Thanks, Jialuo
