On Sun, 11 Nov 2007, Johannes Schindelin wrote: > Hi, > > On Sun, 11 Nov 2007, Daniel Barkalow wrote: > > > On Sun, 11 Nov 2007, Junio C Hamano wrote: > > > > > Daniel Barkalow <barkalow@xxxxxxxxxxxx> writes: > > > > > > > The current code drops extra blank lines between the first line of a > > > > commit message (the summary line) and the remainder. > > > > > > The patch application side does even more. It not just strips > > > off the leading or trailing blank lines, but duplicate blank > > > lines in the middle and trailing whitespaces at the end of each > > > line. > > > > > > I am of two minds about the formatting side. > > > > > > The behaviour you found does not go far enough to correct all of > > > the above whitespace breakage the application side will fix up > > > on the generation side -- it only corrects one of them. We > > > might want to do more, instead of less that you seem to be > > > implying to favor. > > > > What I'm actually doing is working on a cover letter implementation. > > Funny. > > I am in the middle of cleaning out my personal git branch that has a messy > history, since I never rebased, but always merged. Now I decided to go > with rebasing. > > And there I found an implementation of a cover letter. You might want to > be interested ;-) > > http://repo.or.cz/w/git/dscho.git?a=shortlog;h=cover-letter I actually started from the patch you sent me a while back, but using code from pretty.c instead of generating the message directly. I'll have to check whether you added anything since the patch I got. -Daniel *This .sig left intentionally blank* - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
