On Fri, Oct 04, 2024 at 03:47:01PM +0100, Ramsay Jones wrote: > On 04/10/2024 13:16, Patrick Steinhardt wrote: > [snip] > > > Now the two reports are somewhat different from one another: > > > > - On Cygwin we hit timeouts because we fail to lock the "tables.list" > > file within 10 seconds. The renames themselves succeed even when the > > target file is open because Cygwin provides extensive compatibility > > logic to make them work even when the target file is open already. > > Hmm, not so much for me! :( > > > > > - On MinGW we hit I/O errors on rename. While we do have some retry > > logic in place to make the rename work in some cases, this is > > seemingly not sufficient when there is this much contention around > > the files. > > I am seeing I/O errors. Interesting! I wonder why I don't see them. Maybe it's boiling down to timing again. [snip] > Can you think of anything else to try? Not really, no. I'd be curious whether Windows 11 has the same failure mode for Cygwin, but cannot test it myself. > I would strongly suggest skipping this test on cygwin as well as MINGW. Yup, I definitely agree. I was operating under the assumption that Cygwin works alright. Now that we know that it doesn't we should adapt the condition from "!MINGW" to "!WINDOWS". Patrick
