Re: [PATCH] archive: fix misleading error message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 3 Oct 2024 at 17:51, René Scharfe <l.s.r@xxxxxx> wrote:
>
> The error message added by 296743a7ca (archive: load index before
> pathspec checks, 2024-09-21) is misleading: unpack_trees() is not
> touching the working tree at all here, but just loading a tree into
> the index.  Correct it.

>                 init_tree_desc(&t, &tree->object.oid, tree->buffer, tree->size);
>                 if (unpack_trees(1, &t, &opts))
> -                       die(_("unable to checkout working tree"));
> +                       die(_("failed to unpack tree object %s"),
> +                           oid_to_hex(&tree->object.oid));

The existing instance of this message isn't translated, so it'll still
be a new string to translate. Anyway, it's good to use the same wording
here as elsewhere.

There's also a "failed to unpack trees", but here, we're indeed
unpacking *one* tree.

Good catch!

Martin





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux