On Thu, Oct 03, 2024 at 04:43:40PM -0700, Junio C Hamano wrote:
> Jeff King <peff@xxxxxxxx> writes:
>
> > Since we only need the strbuf when we are formatting graph padding, we
> > can give ownership of the strbuf to the git_graph struct, letting us
> > free it when that struct is no longer in use.
> >
> > static const char *diff_output_prefix_callback(struct diff_options *opt, void *data)
> > {
> > struct git_graph *graph = data;
> > - static struct strbuf msgbuf = STRBUF_INIT;
> >
> > assert(opt);
> >
> > if (!graph)
> > return opt->line_prefix;
> >
> > - strbuf_reset(&msgbuf);
>
> Oooh, I love this change. The fewer file scope statics (or global
> states in general) we have, the better ;-).
True, thanks for going the extra mile here! The other patches look good
to me, as well.
Patrick
