On Wed, Oct 02, 2024 at 06:01:18PM -0400, Jeff King wrote: > On Thu, Oct 03, 2024 at 05:01:40AM +0900, Mike Hommey wrote: > > > The jk/unused-parameters topic enabled -Wunused-parameter. Some code in > > some non-typical configuration lacked annotations. > > Thanks, this looks good. I tried to catch compile-time variants like > this, but I was mostly limited to what we build in CI. > > Out of curiosity, what platform do you use that needs NO_ICONV (or is it > just a preference)? I'm just using parts of libgit.a and don't need the iconv support so I disable it. That avoids a dependency on the iconv dll on Windows. Mike
