On Tue, Oct 01, 2024 at 05:37:44PM +0000, Derrick Stolee via GitGitGadget wrote: > From: Derrick Stolee <stolee@xxxxxxxxx> > > In load_cache_entries_threaded(), each thread allocates its own memory > pool. This pool needs to be cleaned up while closing the threads down, > or it will be leaked. > > This ce_mem_pool pointer could theoretically be converted to an inline > copy of the struct, but the use of a pointer helps with existing lazy- > initialization logic. Adjusting that behavior only to avoid this pointer > would be a much bigger change. Thanks, this looks good to me. Patrick