Re: [PATCH] t7005-editor.sh: Don't invoke real vi when it is in GIT_EXEC_PATH

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Nov 11, 2007, at 12:44 PM, Johannes Schindelin wrote:

Hi,

On Sun, 11 Nov 2007, Björn Steinbrink wrote:

The git wrapper executable always prepends the GIT_EXEC_PATH build
variable to the current PATH, so prepending "." to the PATH is not
enough to give precedence to the fake vi executable.

The --exec-path option allows to prepend a directory to PATH even before
GIT_EXEC_PATH (which is added anyway), so we can use that instead.

Hmm. This will probably stop working when you do not have git installed, because you now tell git to search for git programs in ".", where they are not. Probably git-commit executes your installed write-tree, commit- tree
and friends, instead of the compiled ones.

You are wrong there.  From exec_cmd.c:setup_path() (lines 51-54):

    add_path(&new_path, argv_exec_path);
    add_path(&new_path, getenv(EXEC_PATH_ENVIRONMENT));
    add_path(&new_path, builtin_exec_path);
    add_path(&new_path, cmd_path);

So the path with this patch will still include the build directory before the install location.

~~ Brian-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux