On Nov 11, 2007, at 10:58 AM, Johannes Schindelin wrote:
If vi is in GIT_EXEC_PATH, then t7005-editor.sh fails because the
real
vi is invoked instead of the test vi script. This is because the git
wrapper puts GIT_EXEC_PATH ahead of ".". I see no easy solution to
this
problem, and thought I should bring it up with the list.
I don't understand. GIT_EXEC_PATH should be set to the build
directory
when you are running the tests. Unless you copy vi _there_, you
should
not have any problem.
I'm sorry, I should have been more clear. I was referring to the
GIT_EXEC_PATH build variable, not the environment variable. The git
wrapper always adds the path determined during build to the front of
PATH. When I was changing my build script, this got set to "/usr/
local/bin" (I usually use /usr/local/stow/git, instead). Since I have
a /usr/local/bin/vim, PATH for git-commit.sh during the test was:
- my git build directory
- /usr/local/bin (containing a symlink vi -> vim)
- the t/trash directory, added by the test via `PATH=".:$PATH"`
(containing the test vi script)
- my normal path
The test appeared to hang when running it normally. When I ran it
with -v, I saw that vim was started.
~~ Brian
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
