On 9/19/24 6:22 PM, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: >> Second, there are two tests in t5616-partial-clone.sh that I believe are >> actually broken scenarios. While the client is set up to clone the >> 'promisor-server' repo via a treeless partial clone filter (tree:0), >> that filter does not translate to the 'server' repo. Thus, fetching from >> these repos causes the server to think that the client has all reachable >> trees and blobs from the commits advertised as 'haves'. This leads the >> server to providing a thin pack assuming those objects as delta bases. > > In short, the tests are based on broken assumption and checking > bogus outcome? Somebody familiar with the partial clone area should > probably take a look into it and fix the tests if that is the case. That is my understanding, yes. It is a common issue that I've had when using partial clones with multiple remotes and forgetting to modify the filter for each, so is also a usability wart that could use mending (say, by adding the existing filter when adding a new remote). Thanks, -Stolee
