Patrick Steinhardt <ps@xxxxxx> writes: > int reftable_stack_new_addition(struct reftable_addition **dest, > - struct reftable_stack *st); > + struct reftable_stack *st, > + int flags); We usually use "unsigned" for a flag word, i.e., a collection of flag bits. > @@ -1314,6 +1376,7 @@ int cmd_main(int argc UNUSED, const char *argv[] UNUSED) > TEST(t_reftable_stack_reload_with_missing_table(), "stack iteration with garbage tables"); > TEST(t_reftable_stack_tombstone(), "'tombstone' refs in stack"); > TEST(t_reftable_stack_transaction_api(), "update transaction to stack"); > + TEST(t_reftable_stack_transaction_with_reload(), "transaction with reload"); > TEST(t_reftable_stack_transaction_api_performs_auto_compaction(), "update transaction triggers auto-compaction"); > TEST(t_reftable_stack_update_index_check(), "update transactions with equal update indices"); > TEST(t_reftable_stack_uptodate(), "stack must be reloaded before ref update"); Looking good.
