On 2024.09.06 16:45, Junio C Hamano wrote:
> Calvin Wan <calvinwan@xxxxxxxxxx> writes:
>
> > Wrap a few repo setup and config access functions in libgit-sys. These
> > were selected as proof-of-concept items to show that we can access local
> > config from Rust.
> >
> > Co-authored-by: Josh Steadmon <steadmon@xxxxxxxxxx>
> > Signed-off-by: Calvin Wan <calvinwan@xxxxxxxxxx>
> > Change-Id: I6dd886af8c63e1f0f3251064cd8903aecdf768bb
> > ---
>
>
> Common to all other steps, I suspect that you meant to but forgot to
> strip out the Change-Id: thing here?
>
> Also there are a few whitespace breakages in this step.
>
> Applying: libgit-sys: add repo initialization and config access
> .git/rebase-apply/patch:129: trailing whitespace.
> * for the existence of a key rather than a specific value
> .git/rebase-apply/patch:138: trailing whitespace.
> unsafe {
> .git/rebase-apply/patch:143: trailing whitespace.
> unsafe {
> warning: 3 lines add whitespace errors.
>
>
> There is another one in a later step.
>
> Applying: libgit: add higher-level libgit crate
> .git/rebase-apply/patch:325: trailing whitespace.
> // ConfigSet retrieves correct value
> warning: 1 line adds whitespace errors.
Fixed the whitespace errors in V4.
