shejialuo <shejialuo@xxxxxxxxx> writes:
> In "fsck.c::fsck_refs_error_function", we need to tell whether "oid" and
> "referent" is NULL. So, we need to always initialize these parameters to
> NULL instead of letting them point to anywhere when creating a new
> "fsck_ref_report" structure.
>
> The original code explicitly initializes the "path" member in the
> "struct fsck_ref_report" to NULL (which implicitly 0-initializes other
> members in the struct). It is more customary to use " {0} " to express
" {0} " -> "{ 0 }"
> that we are 0-initializing everything. In order to be align with the the
"be align with the the" -> "align with the"
> codebase, initialize "fsck_ref_report" with zero.
Both I'll amend in-place so no need to reroll just for these.
Thanks.
>
> Mentored-by: Patrick Steinhardt <ps@xxxxxx>
> Mentored-by: Karthik Nayak <karthik.188@xxxxxxxxx>
> Signed-off-by: shejialuo <shejialuo@xxxxxxxxx>
> ---
> refs/files-backend.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/refs/files-backend.c b/refs/files-backend.c
> index 8d6ec9458d..890d0324e1 100644
> --- a/refs/files-backend.c
> +++ b/refs/files-backend.c
> @@ -3446,7 +3446,7 @@ static int files_fsck_refs_name(struct ref_store *ref_store UNUSED,
> goto cleanup;
>
> if (check_refname_format(iter->basename, REFNAME_ALLOW_ONELEVEL)) {
> - struct fsck_ref_report report = { .path = NULL };
> + struct fsck_ref_report report = { 0 };
>
> strbuf_addf(&sb, "%s/%s", refs_check_dir, iter->relative_path);
> report.path = sb.buf;
