Patrick Steinhardt <ps@xxxxxx> writes:
[snip]
> +reftable.lockTimeout::
> + Whenever the reftable backend appends a new table to the stack, it has
> + to lock the central "tables.list" file before updating it. This config
> + controls how long the process will wait to acquire the lock in case
> + another process has already acquired it. Default is 1000 (i.e., retry
> + for 1 second).
Isn't the default 100ms? As that was what was mentioned in the commit
message
[snip]
> +test_expect_success 'ref transaction: retry acquiring tables.list lock' '
> + test_when_finished "rm -rf repo" &&
> + git init repo &&
> + (
> + cd repo &&
> + test_commit initial &&
> + LOCK=.git/reftable/tables.list.lock &&
> + >$LOCK &&
> + {
> + ( sleep 1 && rm -f $LOCK ) &
> + } &&
> + git -c reftable.lockTimeout=5000 update-ref refs/heads/branch HEAD
> + )
> +'
Nit: This does stall the test for 1s. Which is slightly annoying when
running single tests locally. Couldn't we achieve this by doing `sleep
0.1`?
Attachment:
signature.asc
Description: PGP signature
